-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Wait task (or Sleep/Delay task) #4879
Comments
Pause is already there for that, moreover pause can be resumed, and free the worker thread for other tasks. |
Yes correct, I'm aware. Pause has to be Resumed (unless you dive deeper to understand how timeout + delay works) -- we need a simple Wait task that will keep the Execution in a RUNNING state -- often needed for process orchestration too |
No, pause can be resume, by default a Pause with a delay do exactly the same as what you propose here except that it frees the worker thread (and allow resuming if for some reason you don't want to wait for so long). |
Hi, is there anyone working on this issue. |
This one would be perfect for you @shabith16 if you want to take it 👍 thanks so much! |
yes I will work on this |
Hi ma'am, I am really interested in contributing to this project I know Java fundamentals (good with DSA) but not have really done any development what should i be learning in order to contribute to this project can you point me in the right direction. |
Maybe try setting up the local env and asking AI like e.g. ChatGPT to help with the first prototype of the plugin? |
yes ma'am. |
Hi ma'am/sir, The proposed idea is to create a plugin named "Sleep." Currently, I am going through the Plugin Developer's Guide. |
Hi @shabith16 we have a Sleep task for testing, you can move out of test directory and update it with the missing parts (mainly documentation). |
yes sir |
sir, |
The backend itself is a bit complex. |
yes sir thank you very much. |
Dear Team, |
Time-off approved! 😄 thanks for being part of our community! |
Hey @anna-geller i know this work has been assigned, but as a beginner can i also try to work on it ? |
Yup, go for it @yoyounik! 🚀 |
Hey @MilosPaunovic @anna-geller i successfully implemented a wait task on my local instance(localhost:8080). Would this be acceptable for now, or should I investigate further to reduce the delay? |
We can't say much like this, without you opening a PR, so will wait for that. |
Got it! I'll go ahead and prepare a PR with the implementation of the wait task. Once it's ready, I'll update here for your review. Thanks for the feedback! |
Hey @MilosPaunovic i have raised a PR titled "Updated time duration to 30 seconds". Please take a look when you get a chance. Thanks. |
Hey @yoyounik I think you misunderstood the issue, the need is to create a new task, not modify the value of a testing flow |
Hey @Skraye |
hello @Skraye Added a new Java class: io.kestra.plugin.core.debug Note: I've temporarily ignored writing test cases to expedite the PR review process. I'll add comprehensive test cases in a follow-up commit once the core functionality is approved. Please review these changes and let me know if you have any questions or require further clarification. |
Thank you all, @Skraye @anna-geller @MilosPaunovic @loicmathieu @tchiotludo so much for the guidance and trust in allowing me to contribute to this project! I'm grateful for your feedback and the chance to work alongside such talented individuals. Your reviews and support helped me improve, and I look forward to contributing again soon! 🙏😊 |
Hi, @yoyounik congratulations. |
sure @shabith16 |
Feature description
Often, even for testing/demo, we need to make execution run for at least X number of seconds/minutes. Atm, we tend to run it in a container or local process, which can be costly + too many lines of code:
It would be useful to add a dedicated tasks for it:
Seems useful for unit testing too.
The text was updated successfully, but these errors were encountered: