Updated time duration to 30 seconds #5594

yoyounik · 2024-10-22T09:35:24Z

What changes are being made and why?

How the changes have been QAed?

Setup Instructions

Skraye · 2024-10-22T09:39:08Z

Hello @yoyounik, can you tell us more about your PR ?

yoyounik · 2024-10-22T09:43:54Z

hello @Skraye
Sure! In this PR, I’ve added a sleep task with a 30-second duration to the test workflow. The purpose of this change is to simulate a wait time between tasks in the workflow to ensure smooth task transitions.
Specifically:

Updated the duration flow to include the sleep task of 30seconds.
2.This change is useful for testing scenarios where a delay is required between task executions.

please let me know if you need more details or have any questions! Thanks for reviewing.

Skraye

As discuss here #4879 the issue has been misunderstood
Please make the change and restore the test as it was

yoyounik · 2024-10-22T18:35:54Z

hello @Skraye
I've made some changes to this PR:

Added a new Java class: io.kestra.plugin.core.debug
Updated the YAML file: core/src/test/resources/flows/valids/wait-task-flow.yaml
The new Java class and YAML file are necessary for implementing the wait task functionality.

Note: I've temporarily ignored writing test cases to expedite the PR review process. I'll add comprehensive test cases in a follow-up commit once the core functionality is approved.

Please review these changes and let me know if you have any questions or require further clarification.

Skraye

Closed to perfection! Small changes and we are good, you can add a test :)

core/src/main/java/io/kestra/plugin/core/debug/Wait.java

core/src/test/resources/flows/valids/sleep.yml

core/src/test/resources/flows/valids/wait-task-flow.yaml

yoyounik · 2024-10-23T07:19:01Z

hey @anna-geller @Skraye
I've added a new test for the wait task in SequentialTest.java.
While running the tests, I encountered some Gradle build warnings related to deprecated features. Here's the relevant part of the output:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0
I'm not familiar with the specific configuration of the Kestra build process. Could you please provide some guidance on how to address these warnings?

Additionally, any feedback on the SequentialTest.java test case would be greatly appreciated.

Skraye · 2024-10-23T07:21:02Z

core/src/main/java/io/kestra/plugin/core/debug/Wait.java

+        @Example(
+            code = """
+                id: wait
+                type: wait.task


This is not a valid type, the example won't work

Skraye · 2024-10-23T07:21:45Z

core/src/main/java/io/kestra/plugin/core/debug/Wait.java

@@ -0,0 +1,55 @@
+package io.kestra.plugin.core.debug;


The package is not the good one, here is the one asked in the original issue :
io.kestra.plugin.core.flow.Sleep
with io.kestra.plugin.core.flow being the package and Sleep being the class name
and this will form the task type

@yoyounik Please read this, better take your times to make correct changes once than doing it 10 times

@Skraye I apologize for the repeated mistakes. I will take my time to ensure that the changes are correct before submitting them again.

Hi @Skraye
Thanks for the feedback. You're right, "Sleep" might be a more descriptive name for the class.

I can rename the Wait.java class to Sleep.java and update the code accordingly. This would keep the file in the io.kestra.plugin.core.flow package.

Does that sound like a good approach?

This is exactly what's need to be done 👍

okay then i will rename it and update you @Skraye

Hey @Skraye
changes i made:
Wait.java changed to Sleep.java,
wait-task-flow.yml changed to sleep-task-flow.yml and changes inside it to Sleep.
sleep.yml's type has been changed.

going to update these changes now, please go through this once, and thanks for the patience shown :).
Please update me if any changes required.

Skraye · 2024-10-23T07:22:38Z

core/src/test/resources/flows/sleep-task.yml

+id: sleep-task-flow
+namespace: io.kestra.tests
+
+tasks:
+  - id: sleep
+    type: io.kestra.core.tasks.scripts.Bash
+    script: sleep 30


Can you remove this ? Never use

done @Skraye

Delete the file, not just remove the content please

hello @Skraye
Updated the changes according to your review, Thanks alot for the review , if you have time to review it once more , please check and tell if there is need of any more modifications.

type: io.kestra.plugin.core.debug.Wait duration: "PT5S"

type: io.kestra.plugin.core.debug.Wait duration: "PT5S" Also updated the wait.java in the flow package

Skraye · 2024-10-23T07:40:43Z

core/src/main/java/io/kestra/plugin/core/flow/Wait.java

+        @Example(
+            code = """
+                id: wait
+                type: io.kestra.plugin.core.debug.Wait


Skraye · 2024-10-23T07:41:11Z

core/src/test/resources/flows/valids/wait-task-flow.yaml

+
+tasks:
+  - id: wait
+    type: io.kestra.plugin.core.debug.Wait


core/src/test/resources/flows/sleep-task.yml

wait-task-flow.yml changed to sleep-task-flow.yml and changes inside it to Sleep. sleep.yml's type has been changed.

yoyounik · 2024-10-23T15:00:49Z

Thanks again @Skraye and everyone for the guiding out throughout the work process. @Skraye do you have any suggestions or guidance on how I can contribute more to the project? I'm excited to keep learning and contributing wherever I can.

Skraye · 2024-10-23T15:03:31Z

We have a full list that are good for learning to work on the project :
https://github.com/kestra-io/kestra/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee

Pick a new one in the list, take your times to understand the issue correctly, and feel free to open another PR!

yoyounik · 2024-10-23T15:24:04Z

Thank you! @Skraye I'll take a look at the list and make sure to fully understand the issues before opening another PR :)

Updated time duration to 30 seconds

8c52603

Skraye self-requested a review October 22, 2024 09:51

Skraye requested changes Oct 22, 2024

View reviewed changes

yoyounik and others added 2 commits October 22, 2024 23:52

added Wait.java class, wait-task-flow.yaml

97eab40

Merge branch 'develop' into add-sleep-task

4efe91a

Skraye reviewed Oct 22, 2024

View reviewed changes

core/src/main/java/io/kestra/plugin/core/debug/Wait.java Outdated Show resolved Hide resolved

core/src/test/resources/flows/valids/sleep.yml Outdated Show resolved Hide resolved

core/src/test/resources/flows/valids/wait-task-flow.yaml Outdated Show resolved Hide resolved

yoyounik added 2 commits October 23, 2024 00:49

updated the duration and added all other changes except test

7acc11e

added the waitTaskTest method for testing

618dcbc

Skraye self-requested a review October 23, 2024 07:20

Skraye requested changes Oct 23, 2024

View reviewed changes

yoyounik added 3 commits October 23, 2024 12:56

removed sleep-task.yml changes

76042b4

removed the type with id: wait

cb0e67d

type: io.kestra.plugin.core.debug.Wait duration: "PT5S"

removed the type with id: wait

6b6a4d6

type: io.kestra.plugin.core.debug.Wait duration: "PT5S" Also updated the wait.java in the flow package

Skraye requested changes Oct 23, 2024

View reviewed changes

yoyounik added 2 commits October 23, 2024 13:16

removed the yaml file update the type

3771ca9

Wait.java changed to Sleep.java,

70a891f

wait-task-flow.yml changed to sleep-task-flow.yml and changes inside it to Sleep. sleep.yml's type has been changed.

MilosPaunovic assigned Skraye Oct 23, 2024

fix(*): polishing

c8b5e88

Skraye force-pushed the add-sleep-task branch from e111a7e to c8b5e88 Compare October 23, 2024 13:01

Skraye merged commit b99d9d4 into kestra-io:develop Oct 23, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated time duration to 30 seconds #5594

Updated time duration to 30 seconds #5594

yoyounik commented Oct 22, 2024

Skraye commented Oct 22, 2024

yoyounik commented Oct 22, 2024

Skraye left a comment

yoyounik commented Oct 22, 2024

Skraye left a comment

yoyounik commented Oct 23, 2024

Skraye Oct 23, 2024

Skraye Oct 23, 2024

Skraye Oct 23, 2024

yoyounik Oct 23, 2024

yoyounik Oct 23, 2024

Skraye Oct 23, 2024

yoyounik Oct 23, 2024

yoyounik Oct 23, 2024

Skraye Oct 23, 2024

yoyounik Oct 23, 2024

Skraye Oct 23, 2024

yoyounik Oct 23, 2024

Skraye Oct 23, 2024

Skraye Oct 23, 2024

yoyounik commented Oct 23, 2024

Skraye commented Oct 23, 2024

yoyounik commented Oct 23, 2024

Updated time duration to 30 seconds #5594

Updated time duration to 30 seconds #5594

Conversation

yoyounik commented Oct 22, 2024

What changes are being made and why?

How the changes have been QAed?

Setup Instructions

Skraye commented Oct 22, 2024

yoyounik commented Oct 22, 2024

Skraye left a comment

Choose a reason for hiding this comment

yoyounik commented Oct 22, 2024

Skraye left a comment

Choose a reason for hiding this comment

yoyounik commented Oct 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yoyounik commented Oct 23, 2024

Skraye commented Oct 23, 2024

yoyounik commented Oct 23, 2024