Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recoverMissedSchedules not working #6027

Closed
jtw549 opened this issue Nov 21, 2024 · 0 comments · Fixed by #6084
Closed

recoverMissedSchedules not working #6027

jtw549 opened this issue Nov 21, 2024 · 0 comments · Fixed by #6084
Assignees
@Skraye
Labels
area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers

Comments

@jtw549
Copy link

jtw549 commented Nov 21, 2024

Describe the issue

I am trying to skip the missed executions...

I set it to NONE for recoverMissedSchedules and it still runs them. The test I am doing is disabling the trigger, not the flow, then wait a few minutes to enable it. As you can see from the image above, it still ran the missing execution. Do Not pay attention to the thing that says recoverMissedSchedules was set to LAST, that was another test I was doing...

I talked to Ludovic and Benoit about this in the slack channel. Below is what Ludovic said:
"I think the disabled is not taking the recoverMissedSchedules params, only stopping of the server will used this configuration"
"confirmed the disabled seem to the main issues here"

Environment

  • Kestra Version: 0.17.8
    flowbackfill1
    flowbackfill2
    flowbackfill3
    flowbackfill4
@jtw549 jtw549 added area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working labels Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 21, 2024
@tchiotludo tchiotludo added kind/customer-request Requested by one or more customers and removed area/frontend Needs frontend code changes labels Nov 21, 2024
@Skraye Skraye moved this from Backlog to In review in Issues Nov 25, 2024
@Skraye Skraye moved this from In review to In progress in Issues Nov 25, 2024
Skraye added a commit that referenced this issue Nov 25, 2024
@Skraye
fix(controller): handle recoverMissedScheduled property of triggers
8f0bbfe 
close #6027
@Skraye Skraye mentioned this issue Nov 25, 2024
Merged
@Skraye Skraye closed this as completed in 43dfd9e Nov 25, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skraye Skraye

Labels
area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): handle recoverMissedScheduled property of triggers kestra-io/kestra
3 participants
@tchiotludo @jtw549 @Skraye