-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/taskitem progress #2433
Merged
Merged
Feat/taskitem progress #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
from
November 3, 2023 15:02
d2df7eb
to
3aee0eb
Compare
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
4 times, most recently
from
November 6, 2023 11:27
3f66bb4
to
c15a09f
Compare
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
from
November 6, 2023 15:38
180a73f
to
bb97b1e
Compare
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
6 times, most recently
from
November 8, 2023 09:47
17c098f
to
95190e1
Compare
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
from
November 8, 2023 11:34
f479385
to
224e68a
Compare
anna-geller
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close #2135 |
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
5 times, most recently
from
November 9, 2023 14:58
ad691ce
to
879dd92
Compare
Skraye
force-pushed
the
feat/taskitem-progress
branch
from
November 9, 2023 20:02
8d15898
to
0a42b0a
Compare
tchiotludo
requested changes
Nov 10, 2023
title = "The iterations counter.", | ||
description = "This output will be updated in real-time with the subflow executions.\n It will contains one counter by subflow execution state, plus a `max` counter that represent the maximum number of iterations (or the number of batches)." | ||
) | ||
private final Map<String, Integer> iterations; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe output is useless like this, please use strong typing:
private Map<State.Type, Integer> states
private Integer max
...
tchiotludo
approved these changes
Nov 10, 2023
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
from
November 10, 2023 14:04
b1fb968
to
207e79c
Compare
loicmathieu
force-pushed
the
feat/taskitem-progress
branch
from
November 10, 2023 14:13
207e79c
to
f50e861
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send a worker task result for :
Thanks to that, outputs are computed in real-time for iterations of executable tasks.