Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/taskitem progress #2433

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Feat/taskitem progress #2433

merged 2 commits into from
Nov 10, 2023

Conversation

loicmathieu
Copy link
Member

@loicmathieu loicmathieu commented Nov 3, 2023

Send a worker task result for :

  • The start of running of a worker task execution
  • The end of running of a worker task execution

Thanks to that, outputs are computed in real-time for iterations of executable tasks.

image

@loicmathieu
Copy link
Member Author

A screenshot from the new UI part:

image

Copy link
Member

@anna-geller anna-geller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! One thing we need to improve is that we should expand this view by default in the same way as other ForEach tasks expand dynamic tasks by default

image

@Skraye
Copy link
Member

Skraye commented Nov 8, 2023

close #2135

@loicmathieu loicmathieu force-pushed the feat/taskitem-progress branch 5 times, most recently from ad691ce to 879dd92 Compare November 9, 2023 14:58
title = "The iterations counter.",
description = "This output will be updated in real-time with the subflow executions.\n It will contains one counter by subflow execution state, plus a `max` counter that represent the maximum number of iterations (or the number of batches)."
)
private final Map<String, Integer> iterations;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe output is useless like this, please use strong typing:

private Map<State.Type, Integer> states
private Integer max
...

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

87.6% 87.6% Coverage
0.0% 0.0% Duplication

@loicmathieu loicmathieu merged commit 16d38a1 into develop Nov 10, 2023
6 checks passed
@loicmathieu loicmathieu deleted the feat/taskitem-progress branch November 10, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants