chore(core): migrate StorageInterface to service-loader mechanism #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhussonnois
force-pushed
the
chore/storage-plugins
branch
15 times, most recently
from
b496e82
to
ba6fc82
Compare
fhussonnois
changed the title
fhussonnois
added
the
kind/breaking-change
loicmathieu
requested changes
Apr 29, 2024
core/src/main/java/io/kestra/core/contexts/KestraBeansFactory.java
Outdated
Show resolved
Hide resolved
Comment on lines
+29
to
+35
| /** | ||
| * Closes any resources used by this class. | ||
| */ | ||
| @Override | ||
| default void close() { | ||
| // no-op | ||
| } |
There was a problem hiding this comment.
Not sure it's a good idea as most if not all storage may have something to close so it's better to mandate thinking about it.
core/src/main/java/io/kestra/core/storages/StorageInterfaceFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/kestra/core/storages/StorageInterfaceFactory.java
Outdated
Show resolved
Hide resolved
fhussonnois
force-pushed
the
chore/storage-plugins
branch
from
ba6fc82
to
7556beb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part-of: kestra-io/storage-minio#80
part-of: kestra-io/storage-s3#80
part-of: kestra-io/storage-gcs#119
part-of: kestra-io/storage-azure#53