feat(ui) Reworked the Trigger page to show only columns that have data #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilosPaunovic
requested changes
Oct 21, 2024
ui/src/components/admin/Triggers.vue
Outdated
| </template> | ||
| </el-table-column> | ||
|
|
||
| <el-table-column column-key="disable" class-name="row-action"> |
There was a problem hiding this comment.
Also, this column seem missing too.
|
@MRADUL9936 Note that Anna do not ask to remove the column, only to hide them if they are empty, however they are still very important |
|
@MilosPaunovic I made changes , can u please review it now . , OUTPUT : |
MilosPaunovic
pushed a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
made changes in ui/src/components/admin/triggers.vue , because this is the parent component which is responsible for
fetching the data from store and rendering the table .
I am using a method to filter out the columns which is having no data , and rendering these columns.
How the changes have been QAed?
Tested in Different Browsers
closes #5546