-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui) Reworked the Trigger page to show only columns that have data #5555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le't try to keep the formatting changes to a minimum, as it will be easier to review PR.
ui/src/components/admin/Triggers.vue
Outdated
</template> | ||
</el-table-column> | ||
|
||
<el-table-column column-key="disable" class-name="row-action"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this column seem missing too.
@MRADUL9936 Note that Anna do not ask to remove the column, only to hide them if they are empty, however they are still very important |
@MilosPaunovic I made changes , can u please review it now . , OUTPUT : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
What changes are being made and why?
made changes in ui/src/components/admin/triggers.vue , because this is the parent component which is responsible for
fetching the data from store and rendering the table .
I am using a method to filter out the columns which is having no data , and rendering these columns.
How the changes have been QAed?
Tested in Different Browsers
closes #5546