Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/system labels #5596

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Feat/system labels #5596

merged 2 commits into from
Oct 22, 2024

Conversation

loicmathieu
Copy link
Member

Part-of: #2059

Introduce system labels which are labels that start with system_ and can't be set by a user.

The first system label, that is also introduced by this PR, is system_correlationId which is set by default in any subflow created by an execution via the Subflow or ForEachItem tasks.
The value of the system_correlationId label is the value of the parent system_correlationId label or the parent execution id if not set.
The Execution API will allow to pass this label at execution creation time but not at any execution modification time.

System labels are labels starting with 'system_', they cannot be set by a user but only Kestra itself.
@loicmathieu
Copy link
Member Author

@anna-geller I didn't allow passing the system_correlationId label via Flow labels at it makes more sense to pass it at execution creation time via the API which I allow. I can however allow it there also if you want.

@loicmathieu loicmathieu added the kind/breaking-change Code modifications needed before upgrading label Oct 22, 2024
@loicmathieu
Copy link
Member Author

Breaking Change

Labels starting with system_ are now reserved for internal Kestra usage so you can no longer use this prefix for your own labels.

Automatically set the 'system_correlationId' label to the parent execution id for all child, recursively.
This label is the only one that can be set once when starting an execution.
Copy link

sonarcloud bot commented Oct 22, 2024

@loicmathieu loicmathieu merged commit 30dab4f into develop Oct 22, 2024
9 checks passed
@loicmathieu loicmathieu deleted the feat/system-labels branch October 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change Code modifications needed before upgrading
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant