Change task run value color to white for readability in ForEach task … #5642
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gantt and Logs views (kestra-io#5445) Signed-off-by: mithindev <mithindev1@gmail.com>
|
@mithindev What does it look when the theme is set to |
|
@MilosPaunovic, This is how it looks in light theme. 
|
|
Awesome, just wanted to double check with you. Note for any further contributions - if you're doing similar kinds of changes, always check both themes. Nice work here! 🚀 |
|
Roger that! Absolutely 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
This PR changes the
smallelement color from--bs-gray-600in the Gantt and Logs views for improved readability, fixing the visibility issue caused by the previous gray color inGantt.vueandTaskRunLine.vue.Closes: #5445
How the changes have been QAed?
Changes have been tested to ensure task run values are clearly visible.