Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update design of blueprint header #5652

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Oct 25, 2024

closes #5583

NOTE: This PR does not touch anything outside of the header.
The table and tags need updates too.

Still needed:

  • Tags
  • Search size and color
  • Pagination button icon and size
  • Table color and spacing
  • Remove tags from table lines

What changes are being made and why?

Dark mode

Screenshot 2024-10-25 at 10 23 57

Light mode

Screenshot 2024-10-25 at 14 47 49

How the changes have been QAed?

Tested on all supported viewports (only with dark mode so far)

@elevatebart elevatebart linked an issue Oct 25, 2024 that may be closed by this pull request
@elevatebart elevatebart changed the title adjust css feat: update design of blueprint page Oct 25, 2024
@elevatebart elevatebart marked this pull request as ready for review October 25, 2024 12:51
Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, everything looks great (except those 2 small comments), but from looking at the issue and the design (#5583), there is more to be done here, right?

The lines need a bit of a cosmetic touch-up, as well as the tags for filtering.

Small note - those two buttons at the top, Community and the Custom Blueprints are only on the EE version, which, as of now, has components for Blueprints which override the ones from OSS version. @brian-mulier-p was changing the setup of how blueprints work recently, so you might want to check with him do we now load custom ones in the same manner as the community ones, if so, you can think of a way to unify the view for OSS and EE, and remove the EE components that override these ones.

I'm here for all the questions, if you have any.

.blueprints {
background: var(--bg-dots-image) no-repeat top left;
background-color: var(--bg-dots-color);
background-size: 1654px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a thinking out loud then anything else, but do we want to hard code the size in pixels?

</template>

<style scoped lang="scss">
@import "@kestra-io/ui-libs/src/scss/variables.scss";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this import is not necessary here, as we use the variable from scss files from styles/layout folder.

@elevatebart elevatebart changed the title feat: update design of blueprint page feat: update design of blueprint header Oct 25, 2024
@anna-geller anna-geller removed their request for review October 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

Adjust the Blueprints page design
3 participants