-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update design of blueprint header #5652
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, everything looks great (except those 2 small comments), but from looking at the issue and the design (#5583), there is more to be done here, right?
The lines need a bit of a cosmetic touch-up, as well as the tags for filtering.
Small note - those two buttons at the top, Community
and the Custom Blueprints
are only on the EE version, which, as of now, has components for Blueprints which override the ones from OSS version. @brian-mulier-p was changing the setup of how blueprints work recently, so you might want to check with him do we now load custom ones in the same manner as the community ones, if so, you can think of a way to unify the view for OSS and EE, and remove the EE components that override these ones.
I'm here for all the questions, if you have any.
.blueprints { | ||
background: var(--bg-dots-image) no-repeat top left; | ||
background-color: var(--bg-dots-color); | ||
background-size: 1654px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a thinking out loud then anything else, but do we want to hard code the size in pixels?
</template> | ||
|
||
<style scoped lang="scss"> | ||
@import "@kestra-io/ui-libs/src/scss/variables.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this import is not necessary here, as we use the variable from scss
files from styles/layout
folder.
closes #5583
NOTE: This PR does not touch anything outside of the header.
The table and tags need updates too.
Still needed:
What changes are being made and why?
Dark mode
Light mode
How the changes have been QAed?
Tested on all supported viewports (only with dark mode so far)