Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Invoke error handling, Integration tests #240

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Improved Invoke error handling, Integration tests #240

merged 1 commit into from
Sep 18, 2023

Conversation

pnedonosko
Copy link
Contributor

Improved Invoke error handling, added integration tests using LocalStack/Lambda.

loicmathieu
loicmathieu approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot.

@pnedonosko
Improved Invoke error handling (show full error as is to the user); A…
c89fd5d 
…dded integration tests within LocalStack/Lambda
loicmathieu
loicmathieu reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the tests didn't pass but as I don't have the log anymore I cannot be 100%sure that it's not caused by this PR so I'll relaunch them before merging.

@pnedonosko
Copy link
Contributor Author

LGTM, the tests didn't pass but as I don't have the log anymore I cannot be 100%sure that it's not caused by this PR so I'll relaunch them before merging.

In the check details it's

io.kestra.plugin.aws.athena.QueryTest ✘ run()

    io.micronaut.context.exceptions.DependencyInjectionException: Failed to inject value for field [accessKey] of class: io.kestra.plugin.aws.athena.QueryTest
    
    Message: Failed to inject value for field [accessKey] of class: io.kestra.plugin.aws.athena.QueryTest

@loicmathieu
Copy link
Member

Yes I saw them, all good, let's merge it!
Thanks a lot!

@loicmathieu loicmathieu merged commit f96e722 into kestra-io:master Sep 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnedonosko @loicmathieu