chore: use the same localstack version in all tests #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
requested changes
Sep 26, 2023
| @BeforeAll | ||
| static void startLocalstack() { | ||
| localstack = new LocalStackContainer(DockerImageName.parse(LOCALSTACK_VERSION)) | ||
| .withServices(LocalStackContainer.Service.S3); |
There was a problem hiding this comment.
The service to start is different on each test, you can pass it via an abstract protected method for eg.
| localstack = new LocalStackContainer(DockerImageName.parse(LOCALSTACK_VERSION)) | ||
| .withServices(LocalStackContainer.Service.S3); | ||
| // some tests use a real flow with hardcoded configuration, so we have to fix the binding port | ||
| localstack.setPortBindings(java.util.List.of("4566:4566")); |
There was a problem hiding this comment.
I wonder if we should'nt allow to configure the local stack before starting it (in an abstract protected method) as not all tst need this port binding and some test may need at some point other thing
moadibfr
force-pushed
the
chore/test_share_localstack
branch
from
1c1335c
to
a95f352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.