-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Energy preserving #67
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@Sondar74 If the user requests q=8, the current code will ignore that and just give a method with q=7. When the code doesn't do what the user requests, it must inform the user of that. So in this case it should throw an error telling the user that the conditions for q>7 have not been implemented. Any time a program does something different from what the user requests, it needs to inform the user of that. |
It's fine. This PR is just a placeholder since this code requires the user to modify the constraint function file directly. If we do merge something into RK-Opt, it will have an interface where the user chooses q through an input parameter. |
Should I modify the code so that q becomes an optional input parameter for the |
I think the next critical task is to fully automate the generation of the MATLAB conditions, so we can be confident that they're correct. |
I modified the |
I have cleaned the previous PR and just kept the
nonlinear_constraints
file.