Update branch, add testing workflow, use implicit none in more Riemann solvers #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aux1,aux2,aux3 , wrong variable size declaration under rpt2_single_layer
These were accidentally added in my last commit.
Remove lines related to experimental 1D geoclaw Riemann solver.
Fix small but confusing typo in instructions for adding Riemann solvers.
Lagrangian gas dynamics with spatially-varying (but temporally constant) entropy.
Add Riemann solver for p-system.
Update rpt2_layered_shallow_water.f90
…nts 4:5 to 0 for Boussinesq code
…build This is only a minor cleanup, it doesn't change behavior. Adding the dependency isn't necessary since Meson 0.63: https://mesonbuild.com/Release-notes-for-0-63-0.html#python-extension-modules-now-depend-on-the-python-library-by-default
Remove the py_dep dependency from extension modules in riemann/meson.build
update rpn2_geoclaw, geoclaw_riemann_utils
* Build 3d Euler with gravity at installation * Fix typo * Add imports to __init__.py
It uses PyClaw's tests since, to my understanding, an ensemble of local regression tests for the Riemann repository using Pytest would require the appropriate argument intents of the rp* subroutines to be explicitly declared already. So the Riemann solvers should be modernized first. Also, the test for shallow water on the sphere is omitted for the moment.
carlosmunozmoncayo
changed the title
The PyClaw test that uses this RS is skipped in the testing workflow since it leads to a core dump (I suspect this has to do with the OS or the system architecture). However, this test passes locally for me (before and after the implicit none changes).
The regression tests in AMRClaw are not being collected by Pytest. They just have to be renamed. This is a temporary fix to run them from this repo in a single pytest session.
|
The behavior of one Riemann solver seems to have changed. The regression tests in |
|
That's very strange, since it's hard to see what is different about that example. I took a quick look but didn't spot anything that seemed likely to cause a problem. |
|
The same test fails if I use the Riemann solvers without the modifications in this PR. The difference between the expected and reference solutions is also the same. I think that the behavior of the Riemann solver was not affected. |
|
Okay. In that case I will merge this and open a PR to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, there are no longer variables with implicit data type in the Riemann solvers. For the moment, the testing workflow is using PyClaw's tests.