Enhanced 'R/r' Handling in Text Replacement #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates replacements so that r or R is not replaced when Rr is the last character or followed by an s.
|
That does sound a lot better, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the text replacement logic to ensure that 'r' or 'R' is not replaced when it is the last character in a word or is followed by an 's'.
This preserves the natural pronunciation of certain words. By keeping 'r' and 'R' unchanged when they are at the end of words or followed by 's', we ensure words like "markers" are transformed to "mawkers" instead of "mawkews". The original replacement often distorted the sound, making words less recognizable.
This change keeps the playful 'UwU' style while ensuring words still sound closer to their original form.
Tested in-game by editing my addon's code.
The update will not affect the addon's performance or other features.