Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adsb exchange clones #95

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat: add adsb exchange clones #95

merged 4 commits into from
Sep 16, 2024

Conversation

shawaj
Copy link
Collaborator

@shawaj shawaj commented Nov 27, 2023

@shawaj
Copy link
Collaborator Author

shawaj commented Nov 27, 2023

Copied comment from #94... At the moment, I am just having a small issue with the MLAT stuff, and I am also going to add the ability to arbitrarily define new services to add (so people can manually do so with environment variables) then will mark as ready for review :-)

@shawaj
Copy link
Collaborator Author

shawaj commented Nov 28, 2023 via email

@Teko012
Copy link
Collaborator

Teko012 commented Dec 19, 2023

I think ENABLE_ALL might be a bit too generic and it can be misleading. I think maybe adding an EXCHANGE_ or some perfix like that could help.

@shawaj
Copy link
Collaborator Author

shawaj commented Dec 19, 2023

I think ENABLE_ALL might be a bit too generic and it can be misleading. I think maybe adding an EXCHANGE_ or some perfix like that could help.

@Teko012 did you read the readme... It has options to enable all or enable one by one :-)

@shawaj
Copy link
Collaborator Author

shawaj commented Dec 19, 2023

I'll try and get this finished up over the holidays. I got a little bit busy and still need to fix some mlat service error messages

@Teko012
Copy link
Collaborator

Teko012 commented Dec 19, 2023

I think ENABLE_ALL might be a bit too generic and it can be misleading. I think maybe adding an EXCHANGE_ or some perfix like that could help.

@Teko012 did you read the readme... It has options to enable all or enable one by one :-)

@shawaj Yes, I just think since enable_all only relates to the exchange ones, not to the other ones (fr24, etc...), it's not all services (but it is a device variable on all service, unless you scope it).

@shawaj
Copy link
Collaborator Author

shawaj commented Dec 19, 2023

@Teko012 ah i see what you mean. So maybe ADSB_EXCHANGE_ENABLE_ALL or similar you mean?

@Teko012
Copy link
Collaborator

Teko012 commented Dec 19, 2023

@shawaj Yes, that was my improvement idea :)

@shawaj
Copy link
Collaborator Author

shawaj commented Dec 19, 2023

@shawaj Yes, that was my improvement idea :)

Cool, good idea. Will change that in next update

@ketilmo
Copy link
Owner

ketilmo commented Dec 19, 2023

Sounds like a great idea. Thanks guys!

@Teko012
Copy link
Collaborator

Teko012 commented Mar 2, 2024

@shawaj Do you need help to finish this off? :)

@shawaj
Copy link
Collaborator Author

shawaj commented May 27, 2024

@shawaj Do you need help to finish this off? :)

Sorry, I have been very busy and this dropped down my to do list but should be resuming it soon.

@Teko012 it basically works no problem it is just that I needed to test the MLAT and fix some error messages. Don't think it'll take that long just haven't had time is all.

If you can help at all it would be much appreciated.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
adsb-exchange/start.sh Outdated Show resolved Hide resolved
adsb-exchange/start.sh Outdated Show resolved Hide resolved
adsb-exchange/start.sh Outdated Show resolved Hide resolved
shawaj added a commit to shawaj/balena-ads-b that referenced this pull request May 27, 2024
As per conversation here ketilmo#95 (comment)

Thanks @Teko012

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Add the following ADS-B Exchange clones:
- [adsb.fi](https://adsb.fi/)
- [ADSB.lol](https://adsb.lol/)
- [ADS-B One](https://adsb.one/)
- [airplanes.live](https://airplanes.live/)
- [Planespotters.net](https://www.planespotters.net/)
- [TheAirTraffic](https://theairtraffic.com/)
- [AvDelphi](https://www.avdelphi.com/)
- [HP Radar](https://adsb.lol/)
- [RadarPlane](https://radarplane.com/)
- [Fly Italy ADSB](https://flyitalyadsb.com/)

Also:
- adds the ability to arbitrarily define similar new services.
- updates ADSB Exchange server addresses as per https://github.com/ADSBexchange/feedclient/blob/643e7ba93e445435e1037406edf9d1e53e24d57b/configure.sh#L141
- apply suggestions from code review as per conversation here ketilmo#95 (comment) (Thanks @Teko012)

Closes: ketilmo#77
Closes: ketilmo#78
Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
@ketilmo
Copy link
Owner

ketilmo commented Jun 1, 2024

Looking forward to this. Let me know if you need any assistance in getting this done.

@shawaj
Copy link
Collaborator Author

shawaj commented Jun 1, 2024

Looking forward to this. Let me know if you need any assistance in getting this done.

I've got another PR coming in next few days and then it should be done. Been testing locally and seems ok on this end. Then should be good to go

@ketilmo
Copy link
Owner

ketilmo commented Jun 1, 2024

Great work, thanks! And thanks to you, @Teko012, for assisting! 👏🏻

@shawaj
Copy link
Collaborator Author

shawaj commented Jul 9, 2024

finishing this one up is next on my list :-P

@shawaj shawaj marked this pull request as ready for review September 16, 2024 16:11
@shawaj
Copy link
Collaborator Author

shawaj commented Sep 16, 2024

think this is ready to test @Teko012 @ketilmo

I am still not sure MLAT results are coming through correctly. But I figured perhaps it is best to get this merged and then keep testing. As the basic feeding and MLAT is working and feeding the services.

Not sure what you think.

@shawaj shawaj requested a review from Teko012 September 16, 2024 16:13
adsb-exchange/start.sh Outdated Show resolved Hide resolved
Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add adsb.fi as a target. [Feature Request] the air traffic feed
3 participants