Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles "down" responsive behavior properly #226

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kettanaito
Copy link
Owner

@kettanaito kettanaito commented Sep 22, 2019

GitHub

Roadmap

  • Add missing integration test for applyStyles() function
  • Rewrite applyStyles() to use a single .reduce()
  • Create prop alias groups of pristine props before generating CSS strings
  • Transform prop alias group's records to close those which go down and have preceding record
  • Add missing E2E tests for multiple "down" responsive props

@kettanaito
Copy link
Owner Author

kettanaito commented Sep 22, 2019

Should cherry pick the missing E2E tests related to the issue from #198

@coveralls
Copy link

coveralls commented Sep 22, 2019

Coverage Status

Coverage increased (+0.3%) to 87.083% when pulling 0a585ff on 119-responsive-down-issue into a76a2bf on master.

@kettanaito
Copy link
Owner Author

I'd like to learn more about a user's expectations when dealing with different combinations of responsive props (especially including contradicting behaviors like up/down pairs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop with explicit "down" behavior overrides implicit "up" behavior of preceding prop
2 participants