Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that stages w/o input are always considered out-of-date / are always rerun. #218

Closed

Conversation

RomeoV
Copy link

@RomeoV RomeoV commented Sep 10, 2024

It was not clear to me from the docs that stages without an input stage are always rerun, thus invalidating any downstream stages.
I just spent half an hour debugging this, and haven't seen this documented clearly. Instead I found it here in the code:

dud/src/index/run.go

Lines 55 to 58 in 1b99eff

if hasCommand && (len(stg.Inputs) == 0) {
doRun = true
runReason = "has command and no inputs"
}

I think it would be good do document it in the dud run docstring, as proposed in this PR.

@kevin-hanselman
Copy link
Owner

Thanks for the contribution! I was hoping that the runReason display text would help with this. Were you unable to see it for some reason?

@RomeoV
Copy link
Author

RomeoV commented Sep 11, 2024

The run reason were not displayed, neither when adding "--trace" nor the "--verbose" flag. I agree they would have surely helped. However, i think it's still worth documenting.

@kevin-hanselman
Copy link
Owner

The run reason were not displayed

What version of dud are you using?

@RomeoV
Copy link
Author

RomeoV commented Sep 13, 2024

Indeed I was on an old version (0.4.3). With 0.4.5, I get the output!
Closing this PR then. Thanks!

@RomeoV RomeoV closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants