Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate render methods no longer in use #130

Closed
kevin-lee opened this issue Sep 5, 2020 · 0 comments · Fixed by #131
Closed

Deprecate render methods no longer in use #130

kevin-lee opened this issue Sep 5, 2020 · 0 comments · Fixed by #131
Assignees
@kevin-lee
Labels
task
Milestone
milestone5

Comments

@kevin-lee
Copy link
Owner

Task

Summary

Deprecate render methods that are no longer in use.

Project Details

Version: 0.4.0

Description

There are methods to render which are no longer in use in favor of
maven2sbt.core.BuildSbt.toListOfFieldValue and maven2sbt.core.BuildSbt.Prop.render
so deprecate these methods.

  • maven2sbt.core.Repository#renderToResolvers - replaced by maven2sbt.core.BuildSbt#renderListOfFieldValue
  • maven2sbt.core.Dependency#renderLibraryDependencies - replaced by maven2sbt.core.BuildSbt#renderListOfFieldValue
  • maven2sbt.core.MavenProperty.render - replaced by maven2sbt.core.BuildSbt.Prop.render
@kevin-lee kevin-lee added the task label Sep 5, 2020
@kevin-lee kevin-lee added this to the milestone5 milestone Sep 5, 2020
@kevin-lee kevin-lee self-assigned this Sep 5, 2020
kevin-lee added a commit that referenced this issue Sep 5, 2020
@kevin-lee
Close #130 - Deprecate render methods no longer in use
f2ccb20
@kevin-lee kevin-lee mentioned this issue Sep 5, 2020
Merged
kevin-lee added a commit that referenced this issue Sep 5, 2020
@kevin-lee
Merge pull request #131 from Kevin-Lee/task/130/deprecate-methods-no-…
542a5e3 
…longer-in-use

Close #130 - Deprecate render methods no longer in use
@kevin-lee kevin-lee mentioned this issue Sep 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-lee kevin-lee

Labels
task
Projects
None yet
Milestone
milestone5
Development

Successfully merging a pull request may close this issue.

Close #130 - Deprecate render methods no longer in use kevin-lee/maven2sbt
1 participant
@kevin-lee