Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GlobalSettings.empty constant #285

Closed
kevin-lee opened this issue Jan 10, 2022 · 0 comments · Fixed by #286
Closed

Make GlobalSettings.empty constant #285

kevin-lee opened this issue Jan 10, 2022 · 0 comments · Fixed by #286
Assignees
@kevin-lee
Labels
task
Milestone
milestone11

Comments

@kevin-lee
Copy link
Owner

Task

Summary

Make GlobalSettings.empty constant.

Project Details

Version: 1.4.0

Description

Make GlobalSettings.empty constant.
GlobalSettings.empty is currently def so it creates a new instance of an empty GlobalSettings whenever GlobalSettings.empty is called. However, GlobalSettings is immutable so there can be only one instance used for any required empty GlobalSettings.
@kevin-lee kevin-lee added the task label Jan 10, 2022
@kevin-lee kevin-lee added this to the milestone11 milestone Jan 10, 2022
@kevin-lee kevin-lee self-assigned this Jan 10, 2022
kevin-lee added a commit that referenced this issue Jan 10, 2022
@kevin-lee
Close #285 - Make GlobalSettings.empty constant
c180568
@kevin-lee kevin-lee mentioned this issue Jan 10, 2022
Merged
kevin-lee added a commit that referenced this issue Jan 10, 2022
@kevin-lee
Merge pull request #286 from Kevin-Lee/task/285/make-GlobalSettings-e…
e39b7bb 
…mpty-constant

Close #285 - Make GlobalSettings.empty constant
@kevin-lee kevin-lee mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-lee kevin-lee

Labels
task
Projects
None yet
Milestone
milestone11
Development

Successfully merging a pull request may close this issue.

Close #285 - Make GlobalSettings.empty constant kevin-lee/maven2sbt
1 participant
@kevin-lee