Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude should not have Scala binary version suffix #327

Closed
kevin-lee opened this issue Jan 2, 2023 · 0 comments · Fixed by #329
Closed

Exclude should not have Scala binary version suffix #327

kevin-lee opened this issue Jan 2, 2023 · 0 comments · Fixed by #329
Assignees
Labels
Milestone

Comments

@kevin-lee
Copy link
Owner

Task

Summary

Exclude should not have Scala binary version suffix.

Project Details

Version: 1.4.0.

Description

The current exclusions look like

exclude("group-id", "artifact-id_${props.scalaBinaryVersion}")
excludeAll(
  ExclusionRule(organization = "group-id", name = "artifact-id_${props.scalaBinaryVersion}"),
  ExclusionRule(organization = "group-id2", name = "artifact-id2"),
)

These should be done like these instead.

excludeAll("group-id" %% "artifact-id")
excludeAll(
  "group-id" %% "artifact-id",
  "group-id2" % "artifact-id2",
)

It is much cleaner this way.

@kevin-lee kevin-lee added the task label Jan 2, 2023
@kevin-lee kevin-lee added this to the milestone11 milestone Jan 2, 2023
@kevin-lee kevin-lee self-assigned this Jan 2, 2023
kevin-lee added a commit that referenced this issue Jan 2, 2023
Close #327 - Exclude should not have Scala binary version suffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant