Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing SAMI file fails when there's no <TITLE> tag #252

Closed
kevin-lee opened this issue May 15, 2023 · 0 comments · Fixed by #253
Closed

Parsing SAMI file fails when there's no <TITLE> tag #252

kevin-lee opened this issue May 15, 2023 · 0 comments · Fixed by #253
Assignees
@kevin-lee
Labels
bug Something isn't working
Milestone
milestone12

Comments

@kevin-lee
Copy link
Owner

Bug

Summary

Parsing SAMI file fails when there's no <TITLE> tag

Project Details

Version:
Scala Version: n/a
Java Version: n/a

Description

If the smi file has no <TITLE> like the following

<SAMI>
<HEAD>
   <STYLE TYPE="Text/css">
   <!--
      .KRCC
   -->
   </STYLE>
</HEAD>
<BODY>
<SYNC START=2000><P Class=KRCC>
...
</BODY>

Any whatsub operation requiring to parse SAMI fails with the following error message

>> Conversion Failed:
>> The smi titled "" of type Smi has no content.

Cause

It fails because the <TITLE> tag is mandatory.

Solution

Make <TITLE> parse optional
@kevin-lee kevin-lee added the bug Something isn't working label May 15, 2023
@kevin-lee kevin-lee added this to the milestone12 milestone May 15, 2023
@kevin-lee kevin-lee self-assigned this May 15, 2023
kevin-lee added a commit that referenced this issue May 16, 2023
@kevin-lee
Fix #252 - Parsing SAMI file fails when there's no <TITLE> tag
bf6be20
@kevin-lee kevin-lee mentioned this issue May 16, 2023
Merged
kevin-lee added a commit that referenced this issue May 16, 2023
@kevin-lee
Merge pull request #253 from Kevin-Lee/task/252/fix-no-title
7ddef9e 
Fix #252 - Parsing SAMI file fails when there's no `<TITLE>` tag
@kevin-lee kevin-lee mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-lee kevin-lee

Labels
bug Something isn't working
Projects
None yet
Milestone
milestone12
Development

Successfully merging a pull request may close this issue.

Fix #252 - Parsing SAMI file fails when there's no <TITLE> tag kevin-lee/whatsub
1 participant
@kevin-lee