Suggestion: Separate argument and instace data

[aristosMiliaressis]

Hi Kevin, i think it's better to separate the argument and instance data, for the following reasons:

• when using the canary search, if a canary flows into a localStorage.setItem call (or any other method that assigns values to its instance), all subsequent localStorage.setItem calls will be matched as containing the canary.
• when viewing the data passed into the sink it can be very hard to visually recognize where instance data ends and argument data starts.

maybe you can solve the second issue by just separating the "Data passed into the sink" popup with a horizontal line, so you dont have to add an extra column.

[kevin-mizu]

Hi 👋

Sorry for the delay, I haven’t been very active on the project recently! That said, I think your suggestion is a good one. The main issue here is that I want to be able to filter both the thisArg and the sink’s data at the same time, since the user input could be present in either.

Maybe we could start by updating the separator from ";" to "|" and see how convenient that is in the next release? I'll also add a new config option to make the printing of the thisArg value optional, which could be useful for sink-specific cases.

Cheers,
Kévin

[kevin-mizu]

It should be better now :D

Thanks for reporting this issue! It will be integrated in the next release 🎉