Process streamed data #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to implement #161 by adding a new option without too many overhead.
This solution is not optimal:
StreamedOption. This allows the option to be introduced with minimal code changes, but breaks with the option model used so far. Maybe this is OK, because the user has no change to activate this option from the outside: only the newDeserializeStreammethod uses this wrapper.ExpectEndOfStream) is somewhat strange - see Deserialize multiple objects from stream #161 for details.I would love to see this (or a better) solution merged. Don't hesitate to yell at me, if I've done anything completely wrong or can assist further in implementation.
Many thanks in advance.