Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly patch HTTPConnection.request for Python 3.6 #294

Merged
merged 3 commits into from
May 2, 2017
Merged

Correctly patch HTTPConnection.request for Python 3.6 #294

merged 3 commits into from
May 2, 2017

Conversation

derekbekoe
Copy link
Contributor

Fixes #293

@lamenezes
Copy link
Collaborator

Nice PR @derekbekoe!

Do you think you could add some tests that reproduce the bug reported in issue #293?

@derekbekoe
Copy link
Contributor Author

Will take a look!

@derekbekoe
Copy link
Contributor Author

Testing this requires adding Python 3.6 to Travis CI.
I did this and other tests fail because of changes to HTTPConnection (https://docs.python.org/3.6/library/http.client.html) which VCRConnection is based from (though not a subclass of).

I don't have time right now to fix up all tests for full Python 3.6 support with VCR.
I have reverted the change to .travis.yml for now.

@kevin1024 kevin1024 mentioned this pull request Mar 22, 2017
Merged
@graingert graingert merged commit 091b402 into kevin1024:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekbekoe @lamenezes @graingert