Pin yarl and multidict version for python34 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea why the flake8 tests in python3 can succeed in some travis jobs. It should always fail. 😕 This PR also fix the flake8 tests in travis CI. |
|
@jxltom thanks for your PR! It looks great to me 🙂
I've had similar problems on another project. Code was passing OK on flake8 but with a new flake8 version builds started to fail xD Thanks again! 🔝 ⚽ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #342, #393
Thanks @5j9, this PR is made according to the info your provided.
I will appreciate that if anyone can review just in case I'm missing anything.
@5j9 @lamenezes