Fix not working for binary response in httpx #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except (TypeError, UnicodeDecodeError, AttributeError): | ||
| # Sometimes the string actually is binary or StringIO object, | ||
| # so if you can't decode it, just give up. | ||
| pass |
There was a problem hiding this comment.
Yes, httpx can take bytes. That's why the content is encoded back to bytes in _from_serialized_response when constructing httpx.Response. The decode is for serializing the VCR response, not for httpx. If you take out the decode, I believe you will get !!binary in the serialized yaml even for plain text. I guess reason of decoding the data into unicode is trying to have human readable yaml file. This unicode / bytes conversion happens in other libraries as well, but it is done in for the body field only. Therefore, I suggest the better fix should be having a consistent serialization schema for all libraries, which is discussed in #463.
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c
to
34d5384
Compare
|
Also fixed in #784 |
|
I suggest we close this one in view of #784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
httpx_reponse.content.decode("utf-8", "ignore")would corrupt binary content that can't decoded to unicode. We should serialize the binary content directly in that case.A better way to fix this is probably is set the content to
response["body"]["string"]becausevcr.serializers.compat.convert_to_unicode()andvcr.serializers.compat.convert_to_bytes()handle the bytes / unicode conversion of that field. But that will change the cassette format for httpx. I guess you guys can consider that when implementing #463.