Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Sensitive UUID #10

Closed
kevincar opened this issue Nov 28, 2020 · 0 comments · Fixed by #43
Closed

Case Sensitive UUID #10

kevincar opened this issue Nov 28, 2020 · 0 comments · Fixed by #43
Assignees
Labels
bug Something isn't working

Comments

@kevincar
Copy link
Owner

The problem
server.services is currently a dictionary, accessed by a string representation of the associated UUID. This can cause issues if the UUID was initially supplied as all upper-case or all lower-case. Regardless of how it is supplied, an interfaces should be supplied that standardizes the casing.

Reproduction
Can be readily reproduced on the windows branch when running against the example/server.py

Expected behavior
A UUID, whether provided in upper- or lower-case, should be handled appropriately. PyTests should account for this

Desktop (please complete the following information):

  • OS: Windows (But likely could apply to macOS as well)
@kevincar kevincar added the bug Something isn't working label Nov 28, 2020
@kevincar kevincar self-assigned this Nov 28, 2020
kevincar added a commit that referenced this issue May 16, 2021
kevincar added a commit that referenced this issue May 16, 2021
kevincar added a commit that referenced this issue May 16, 2021
@kevincar kevincar linked a pull request May 16, 2021 that will close this issue
@kevincar kevincar mentioned this issue May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant