Ensure we do not corrupt the userTypeAttr definition when encountering a boolean false value #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the original value
kevinchappell
approved these changes
Sep 21, 2023
|
🎉 This PR is included in version 3.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user configured a userTypeAttr with
value: falsebut notype: checkboxthe origValue calculation in processTypeUserAttrs would set the false to '' , this would cause the typeUserAttrs value definition to be changed when resetting the tUA.value to the original value.This had the affect that when additional fields are added with this typeUserAttrs, processTypeUserAttrs would see the value as type string and output a textbox instead of a checkbox.
value: true would be detected as boolean and always kept as boolean. This PR ensures value: false works the same way.
One of the issues raised in #915