Fix for https://github.com/kevinchappell/formBuilder/issues/699 #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingle input[type=text] value. Formatting of TextAreas is now preserved.
Shinbar
changed the title
|
Thank you @Shinbar for your PR. I'll will review |
lucasnetau
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Hi @Shinbar thanks for the PR. I've added some comments and suggested changes.
|
Also, if possible can you please adjust your commit message to include the prefix 'fix: ' so it becomes fix: For TextArea control have made the value input a textarea and not a single input[type=text] value. Formatting of TextAreas is now preserved. |
Co-authored-by: James Lucas <james@lucas.net.au>
Co-authored-by: James Lucas <james@lucas.net.au>
Co-authored-by: James Lucas <james@lucas.net.au>
Shinbar
changed the title
…t a single input[type=text] value. Formatting of TextAreas is now preserved. Update src/js/form-builder.js Co-authored-by: James Lucas <james@lucas.net.au>
…t a single input[type=text] value. Formatting of TextAreas is now preserved.
|
LGTM @kevinchappell any issues with this change for textareas? |
kevinchappell
approved these changes
Dec 8, 2023
|
🎉 This PR is included in version 3.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recently using this great project, I found that TextArea content are not being preserved, as they are being converted into a single value input of input[type=text]. This removes formatting from the TextArea such as line feeds etc.
I have amended the code so that TextArea are provided a proper TextArea control, and that the innerHTML data is preserved.
I believe this solved the following issue.
Fixes: #699