-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow custom controls to add one or more Option based attributes #1510
base: master
Are you sure you want to change the base?
Conversation
@kevinchappell WIP for the options code. Would like you opinion on the flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, i never finished my review. this mostly looks good to me. i will take a swing at fixing the test and it should be good to merge after.
@@ -17,3 +17,9 @@ console.error = (...params) => { | |||
originalConsoleError(...params) | |||
} | |||
} | |||
|
|||
import { webcrypto } from 'node:crypto' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
I have one more change to push to this. A button to switch from option => value to just an option (and value is equal to option). Useful for lists. |
d49590a
to
d03c286
Compare
Restoring state in formBuilder for this attribute type currently needs to be implemented |
… icon are on same line
…stored in attribute name key
6f7229b
to
3dfaae2
Compare
Allow adding Option attributes to custom controls (or when a template overrides a builtin control)
This can be defined by assigning the type: options
noSelect: flag can be set to true to hide the radio select buttons (where selecting options isn't used by the control).
Example definition:
@todo: Support a no-value option
Resolves: #647
Resolves: #866
Resolves: #825
Resolved: #1129