feat!: change unit enums to objects #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
Comment on lines
+24
to
+48
| public val Decimilliare: AreaUnit = object : AreaUnit { | ||
| override val symbol: String = "dma" | ||
| override val millimetersSquaredScale: Long = 100 | ||
| } | ||
| public val Centiare: AreaUnit = object : AreaUnit { | ||
| override val symbol: String = "ca" | ||
| override val millimetersSquaredScale: Long = 1_000_000 | ||
| } | ||
| public val Deciare: AreaUnit = object : AreaUnit { | ||
| override val symbol: String = "da" | ||
| override val millimetersSquaredScale: Long = 10_000_000 | ||
| } | ||
| public val Are: AreaUnit = object : AreaUnit { | ||
| override val symbol: String = "a" | ||
| override val millimetersSquaredScale: Long = 100_000_000 | ||
| } | ||
| public val Decare: AreaUnit = object : AreaUnit { | ||
| override val symbol: String = "daa" | ||
| override val millimetersSquaredScale: Long = 1_000_000_000 | ||
| } | ||
| public val Hectare: AreaUnit = object : AreaUnit { | ||
| override val symbol: String = "ha" | ||
| override val millimetersSquaredScale: Long = 10_000_000_000 | ||
| } | ||
| public val entries: List<AreaUnit> = listOf(Decimilliare, Centiare, Deciare, Are, Decare, Hectare) |
There was a problem hiding this comment.
I think it might make sense to make all of these getters? Eg.
private val Decimilliare: AreaUnit get() = object : AreaUnit { ... }There was a problem hiding this comment.
Sure. I generally don't like that pattern because the objects lose their name and and become anonymous objects.
There was a problem hiding this comment.
Actually, on second thought -- I think we should pause this until #42 is complete. Each of these being anonymous objects is pretty awkward and this will likely significantly change once the work in the above issue is completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite for #58