First action test #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates our install guide to include Python, needed for many of our scripts. Commit log: * scripts/*.py files updated to use python3 * hashbang reflects use of python3 in .py files * Python dependency noted in Installation guide * Install script edits * syntax errors fixed * scripts/*.py files updated to use python3 * hashbang reflects use of python3 in .py files * Python dependency noted in Installation guide * Install script edits * syntax errors fixed * fixed syntax errors * spacing errors fixed * addressing pylint errors * switched exit(1) to sys.exit(1) given pylint suggestion * cleaned up print statements
Fixes an issue where port mask was being calculated incorrectly. Commit log: * Fixed bug in sdnfv#228 * Changed dependency checking to be more OS-agnostic * Forcing workflow rerun * Forcing workflow rerun * Improved dependency check * Simplified port counting * Added comments for port conversions * Moved port check to prevent future merge conflict
Adds a note into our documentation reminding users to submit PR's to develop branch. Commit log: * Added reminder for users to submit PR's to develop instead of master * Punctuation
We now fake the mac address where real MAC addresses are not necessary. Commit log: * mac address fix * undoing load balancer change * adding print statement * spacing fix * print statement for speed tester
Updates the tx_burst function to properly account for out stats. Commit log: * Update stats for outgoing packets * Test if perf drop is gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<>
Summary:
Usage:
Merging notes:
TODO before merging :
Test Plan:
Review:
(optional) << @-mention people who should review these changes >>
(optional) Subscribers: << @-mention people who probably care about these changes >>