Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to support React 17 #91

Closed
wants to merge 1 commit into from
Closed

Updated to support React 17 #91

wants to merge 1 commit into from

Conversation

kevinfarrugia
Copy link
Owner

What's Changing

No new features but upgrading to support React 17 and therefore a breaking change.

Change Type

  • documentation
  • patch
  • minor
  • major

@kevinfarrugia kevinfarrugia added the major create a major release label Dec 21, 2021
@kevinfarrugia kevinfarrugia mentioned this pull request Dec 21, 2021
@zalcode
Copy link

zalcode commented Jan 24, 2022

hi @kevinfarrugia
when you merge this PR ?
image
the current v3 is still using old deps

@alex-udisc
Copy link

Hey @kevinfarrugia! I'm looking to use this carousel in a nextJS app using React 17. Any chance this gets merged soon? I'm am trying to test this version locally, but I'm not totally sure how to pull down this change as an npm module.

@kevinfarrugia
Copy link
Owner Author

Hi @alex-udisc I will take a look this weekend. What issues are you encountering when running it on React 17 please?

@alex-udisc
Copy link

alex-udisc commented Jan 31, 2022

Hi @alex-udisc I will take a look this weekend. What issues are you encountering when running it on React 17 please?

@kevinfarrugia I was unable to pull down this commit, build it, and use it in an application. I'm not sure if I'm doing that process properly, so I'm not sure if I found a legitimate failure or bug.

If there is an article or if you could provide a quick explanation of how to test this commit locally, I would give it a try today or tomorrow.

@kevinfarrugia
Copy link
Owner Author

@alex-udisc I created a new NextJS project using react: 17.0.2 and react-glider: 3.0.0 and it is working correctly. As such, I expect that it should work for you too.

Could you please help me understand what issue you are encountering when using React 17 please?

Repo: https://github.com/kevinfarrugia/next-react-glider
Demo: https://next-react-glider.vercel.app/

@alex-udisc
Copy link

@alex-udisc I created a new NextJS project using react: 17.0.2 and react-glider: 3.0.0 and it is working correctly. As such, I expect that it should work for you too.

Could you please help me understand what issue you are encountering when using React 17 please?

Repo: https://github.com/kevinfarrugia/next-react-glider Demo: https://next-react-glider.vercel.app/

@kevinfarrugia Thanks for responding, let me try to explain why I wrote to you in the first place.

When I install react-glider@3.0.0, React 16 is still a peer dependency:

Screen Shot 2022-01-31 at 12 35 01 PM

I think this is caused by other dependencies still requiring react 16. I guess I'm looking for React 17 support that will not require React 16 in any way. Does this make sense?

@kevinfarrugia
Copy link
Owner Author

Understood. Will look into it.

@hipstersmoothie
Copy link
Collaborator

🚀 Issue was released in v3.0.1 🚀

@kevinfarrugia
Copy link
Owner Author

v3.0.1 should resolve the issue with React since the previous version had a peerDependency on React v16.

Storybook update will be done in a separate PR. See #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major create a major release released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants