-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to support React 17 #91
Conversation
hi @kevinfarrugia |
Hey @kevinfarrugia! I'm looking to use this carousel in a nextJS app using React 17. Any chance this gets merged soon? I'm am trying to test this version locally, but I'm not totally sure how to pull down this change as an |
Hi @alex-udisc I will take a look this weekend. What issues are you encountering when running it on React 17 please? |
@kevinfarrugia I was unable to pull down this commit, build it, and use it in an application. I'm not sure if I'm doing that process properly, so I'm not sure if I found a legitimate failure or bug. If there is an article or if you could provide a quick explanation of how to test this commit locally, I would give it a try today or tomorrow. |
@alex-udisc I created a new NextJS project using Could you please help me understand what issue you are encountering when using React 17 please? Repo: https://github.com/kevinfarrugia/next-react-glider |
@kevinfarrugia Thanks for responding, let me try to explain why I wrote to you in the first place. When I install react-glider@3.0.0, React 16 is still a peer dependency: I think this is caused by other dependencies still requiring react 16. I guess I'm looking for React 17 support that will not require React 16 in any way. Does this make sense? |
Understood. Will look into it. |
🚀 Issue was released in |
Storybook update will be done in a separate PR. See #99 |
What's Changing
No new features but upgrading to support React 17 and therefore a breaking change.
Change Type
documentation
patch
minor
major