Admin Next Team Create #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
force-pushed
the
team-create
branch
from
b9e8ec2
to
53e1ea1
Compare
kevinhughes27
force-pushed
the
team-create
branch
from
53e1ea1
to
d7e6b4c
Compare
kevinhughes27
commented
Jul 29, 2018
| isSeeded: false | ||
| }, | ||
| seed: 0 | ||
| }; |
There was a problem hiding this comment.
this is the issue with the single type definition. Not everywhere uses all the parts of the type. A follow up PR will generate types from the Query
kevinhughes27
commented
Jul 29, 2018
| @@ -33,12 +35,13 @@ class TeamList extends React.Component<Props> { | |||
| {teams.map((t: Team) => <TeamListItem key={t.id} team={t}/>)} | |||
| </TableBody> | |||
| </Table> | |||
| <ActionButton onClick={() => this.props.history.push("/teams/new")}/> | |||
There was a problem hiding this comment.
Eventually this will probably be a speed dial floating button that expands to multiple actions like import and export
https://material-ui.com/lab/speed-dial/
kevinhughes27
commented
Jul 29, 2018
| ); | ||
| } else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
There is an open issue to fix the types so that typescript knows that Theme will be present when withTheme: true is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #750
This PR adds the team create mutation and form for a new team. Code re-use went pretty well but this work exposed issues with the manually defined types (this will be addressed in the next PR).