ESP8266 and passive mode fixes #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP8266 appears to always return `1` from `UART.any()` When in passive mode, the sensor will only reply with a frame if a `0xe2` command is sent. If the sensor is already in passive mode and the controller restarts, `wakeUp` would not request data and therefore never mark the device as alive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1fromUART.any(), which is documented as a possibility. I added a check to determine if we're running on an ESP8266 and set the expected frame length to 1 when waiting for a response in_sendCommand.0xe2command is sent per the docs. If the sensor is already in passive mode and the controller restarts,wakeUpwould not send this command to request data and therefore never mark the device as alive.