add sample cors test #123
add sample cors test #123
Conversation
|
@ldsmoreira i'll get this merged, then we can merge that into your branch and you can expand and duplicate it to test all the functionality that you've added over in #118 |
| // we dont have preflight support implemented yet so we expect nothing to happen here | ||
| if (server.last_responses.size() != 0) | ||
| throw std::logic_error("Cors preflight is not implemented but we got a response"); |
There was a problem hiding this comment.
@ldsmoreira once we get this merged to master and then merged into your branch, you can change this bit here to check that the shortcircuiter replied properly here
| void test_cors_preflight() { | ||
| // a server who lets us snoop on what its doing | ||
| zmq::context_t context; | ||
| testable_http_server_t server(context, "ipc:///tmp/test_http_server", |
There was a problem hiding this comment.
you'll probably also need to configuration your shortcircuiter here as well
|
Hello @kevinkreiser !! Nice!! |
|
@ldsmoreira it seems that the CI has been updated and it was causes any mac builds to fail. ive opened another pr and merged that, which fixes this (for the tiem being). i've merged it into this branch now and thsi shoudl finally pass CI and i can merge this and unblock you. apologies! |
this is an example that we can expand and duplicate to get the shirtcirtuiters cors functionality merged