Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webrick 1.8 to Gemfile #51

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Add webrick 1.8 to Gemfile #51

merged 2 commits into from
Jun 15, 2024

Conversation

jesse-wei
Copy link
Contributor

Adds a dependency to Gemfile that fixes #50.

@kevinlin1
Copy link
Owner

Looks good to me. Thanks for submitting the issue and patch.

@kevinlin1 kevinlin1 merged commit 4739668 into kevinlin1:main Jun 15, 2024
@kevinlin1
Copy link
Owner

GitHub Pages gem v232 now automatically adds webrick, so I believe this patch isn't necessary anymore thanks to this upstream pull request: github/pages-gem#914

I will look into this more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README inaccurate instructions for local dev
2 participants