Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
'input
lifetime parameter toParseElem
and changes changes the signature ofparse_elem
to takeself
by&'input
.This change allows
ParseElem
implementations that returnElement
s by reference, avoiding a potentially expensiveclone()
. Case in point, the implementation ofparse_elem
inParseElem for [T]
now returns&'input T
.Both of these are breaking changes.
Closes #268.