Skip to content

Commit

Permalink
Remove patch for Sidekiq::Processor#process_one
Browse files Browse the repository at this point in the history
According to the discussion in open-telemetry#535, we can better match spec by
avoiding the `sidekiq::processor#process_one` span altogether. This
fixes the issues described in open-telemetry#535 and open-telemetry#544.
  • Loading branch information
kevinnio committed Jul 6, 2023
1 parent cc244b9 commit a1aa8c3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 102 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class Instrumentation < OpenTelemetry::Instrumentation::Base
option :trace_launcher_heartbeat, default: false, validate: :boolean
option :trace_poller_enqueue, default: false, validate: :boolean
option :trace_poller_wait, default: false, validate: :boolean
option :trace_processor_process_one, default: false, validate: :boolean
option :peer_service, default: nil, validate: :string

private
Expand All @@ -45,15 +44,13 @@ def require_dependencies
require_relative 'middlewares/client/tracer_middleware'
require_relative 'middlewares/server/tracer_middleware'

require_relative 'patches/processor'
require_relative 'patches/launcher'
require_relative 'patches/poller'
end

def patch_on_startup
::Sidekiq.configure_server do |config|
config.on(:startup) do
::Sidekiq::Processor.prepend(Patches::Processor)
::Sidekiq::Launcher.prepend(Patches::Launcher)
::Sidekiq::Scheduled::Poller.prepend(Patches::Poller)
end
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit a1aa8c3

Please sign in to comment.