Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowClear Button (type search) and allow empty value #126

Merged
merged 4 commits into from
May 24, 2022

Conversation

JonathanSchndr
Copy link
Contributor

Hello everyone 👋,

I think this plugin is great so I removed 2 issue and added 1 new feature. For both issues I updated the docs.

  1. fix: docs now load the local dist folder, for better development and downgrade docs to CDN Vue 2
  2. new: AllowClear allows to change the input type to search and thus get a clear button (HTML default)
  3. fix: It is possible to empty the input ('') and thus get a really empty string.

To point 3:
It was already possible to define an emptyValue: ''. Unfortunately this did not work. This is solved by the PR.
Reason: The Process method has overwritten by the update this again and again with 0. Likewise also the Focus Handler. The Lib Accounting-JS, for formatting, also made from a '' always 0. The bugfix now always checks the type before. If it should be an empty string, it returns this directly. In addition, it has also been removed that a 0 always becomes NULL automatically to prevent the user from really wanting to enter a 0 as a number.

Looking forward to your feedback. 🙏

This PR should resolve the following issues: #117 #57

Verified

This commit was signed with the committer’s verified signature.
danepowell Dane Powell
@JonathanSchndr
Copy link
Contributor Author

This PR is very important for further work. Alternatively, I am happy to set up a vue-numeric2, if there is no more time to continue this project?

@kevinongko kevinongko merged commit 34be3d4 into kevinongko:master May 24, 2022
@kevinongko
Copy link
Owner

kevinongko commented May 24, 2022

Merged, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants