Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple search for search feature #5

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Add multiple search for search feature #5

merged 2 commits into from
Aug 12, 2019

Conversation

JosephT5566
Copy link
Contributor

Dear kevinptt0323,
我新增了多重搜尋的功能，再請你幫忙review~ 看有哪裡需要修改或是建議
Thanks~

Changes

  1. Add multiple search feature.
  2. Add correspond unit test.

@JosephT5566
[Feature] Add feature: multiple search
8fd6717 
1. Add multiple search feature.
2. Add correspond unit test.
kevinptt0323
kevinptt0323 reviewed Aug 10, 2019
View reviewed changes
Copy link
Owner

@kevinptt0323 kevinptt0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝，只有一些命名&OOP的小問題！

src/sites/ptt/bot.js Outdated Show resolved Hide resolved
src/sites/ptt/bot.js Outdated Show resolved Hide resolved
src/sites/ptt/bot.js Outdated Show resolved Hide resolved
@kevinptt0323 kevinptt0323 merged commit 3e92281 into kevinptt0323:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinptt0323 kevinptt0323 kevinptt0323 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosephT5566 @kevinptt0323