Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for custom configuration files #9

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

kevintyj
Copy link
Owner

What is the purpose of this PR?

Adds the ability for users to input a explicit javascript configuration file path for commitlint

ClickUp/Jira/Github project ticket number(s)?

What did you do?

Add a GitHub action input cl-config for the file path for commitlint on the repository.
README updated to reflect changes

How do we test it?

Vitest tests passing & coverage unchanged.

Checklist before merging

  • Added tests where necessary
  • Performed a self-review of my code
  • Ensure all acceptance criteria are met
  • Implemented the UI as exactly as the design (applicable only for UI changes)
  • Added comments for codes where hard-to-understand
  • Haven't pushed unnecessary files (ex: .env, .map)
  • Haven't ignored Typescript warnings in the code (if do so add a comment with the reason)

Provide screenshot details of the PR

[optional] Tests passed screenshot

[optional] Breaking changes after PR

Anything else?

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@43be185). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff            @@
##             main        #9   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?       123           
  Branches        ?        23           
========================================
  Hits            ?       123           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevintyj kevintyj merged commit 3256453 into main Nov 24, 2023
4 checks passed
@kevintyj kevintyj deleted the feat/custom-config branch November 24, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant