-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to process.py logging #2005
Improvement to process.py logging #2005
Conversation
LGTM, what about you @kevoreilly ? |
I've just tested it and seen that the log spamming that apparently prompted me to disable the
|
If we can quiten these messages down to an 'acceptable' level then I think it should be ok. |
537f369
to
46ea175
Compare
Log the image name as well as the process ID; added tests. Also, restore the process is_alive check, disabled 4 years ago. Consequently, commented out excessive logging. Credit: @nbargnesi
46ea175
to
ac79838
Compare
I've commented out the verbose / spammy logging, @kevoreilly @doomedraven I squashed the commits back down to one, and now I realize I probably shouldn't have, sorry. Anyhow, that's what I did. Let me know if any questions. |
im not having time right now to test, was you able to test @kevoreilly latest commit? if no i will do that in 1-2 days |
Yep I'll test it tomorrow |
no rush but please take another look when you get a chance |
I've been running this on my main server for the last few days - I just need to check the logs. |
I wonder if this line is ok:
Is |
The new
def __str__(self):
"""Get a string representation of this process."""
image_name = self.get_image_name() or "???"
return f"<{self.__class__.__name__} {self.pid} {image_name}>" |
Thank you! |
Log the image name as well as the process ID; added tests.
Also, restore the process is_alive check, disabled 4 years ago.
Credit: @nbargnesi
Sample log entries: