Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional process.file_activities to link pid with files #2199

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

xiangchen96
Copy link
Contributor

No description provided.

@doomedraven doomedraven merged commit 087f75c into kevoreilly:master Jul 1, 2024
5 checks passed
@ethhart
Copy link

ethhart commented Oct 15, 2024

I know capa isn't used in your implementation, but am aware of some of the linkages and see some activity from you guys on the capa repo, so wanted to make you aware that this change breaks the cape model defined in the current version of capa https://github.com/mandiant/capa/blob/master/capa/features/extractors/cape/models.py#L301

Either the results shouldn't contain the empty dict by default (two different models now that have to be accounted for if the file_activites option is enabled which will just be implemented through Optional qualifiers) or (ideally) the capa model needs to be updated. I apologize that I am unable to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants