Allow custom config dirs that extend the default ones. #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2022 17:42
A new custom/conf/ directory can be used to hold additional
configuration files that extend the ones in the top-level conf
directory. See the custom/README.md for more information.
`.conf.d` (e.g. `custom/conf/reporting.conf.d/`) directories may also
be used to store additional configuration.
In addition, for Config() objects, only read the files once, so that if,
say, Config("processing") is created in multiple places, they'll both
refer to the same object and the conf files would only be read once.
A new AnalysisConfig() class was created to separate the distinction
between these types of "singleton" Config objects that can read from
multiple directories versus ones that just read from an analysis.conf
(or some other single file).
Allow environment variables to be referenced in config files.
Allow config files to use values that are formatted like
%(ENV:SOME_ENVIRONMENT_VARIABLE)s. In certain deployment strategies,
this makes it easier to deal with secrets since they don't need to be
stored on disk anywhere.
Config.get() should only return the items that were actually in the config file.
|
as far as i understand this commit overwrites this one no? #711 |
|
yes. I'll close that one. |
|
oops. I can't, because you created it. :-) |
|
ok closing that one |
|
tested, works fine, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new custom/conf/ directory can be used to hold additional
configuration files that extend the ones in the top-level conf
directory. See the custom/README.md for more information.
.conf.d(e.g.custom/conf/reporting.conf.d/) directories may alsobe used to store additional configuration.
In addition, for Config() objects, only read the files once, so that if,
say, Config("processing") is created in multiple places, they'll both
refer to the same object and the conf files would only be read once.
A new AnalysisConfig() class was created to separate the distinction
between these types of "singleton" Config objects that can read from
multiple directories versus ones that just read from an analysis.conf
(or some other single file).
Allow environment variables to be referenced in config files.
Allow config files to use values that are formatted like
%(ENV:SOME_ENVIRONMENT_VARIABLE)s. In certain deployment strategies,
this makes it easier to deal with secrets since they don't need to be
stored on disk anywhere.