Fix recurrence iteration where there is a BYMONTHDAY rule greater than the number of days in the start month. #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3019342029
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3416378920
💛 - Coveralls |
darktrojan
force-pushed
the
overflow-bymonthday
branch
from
59a6e3b to
455b663
Compare
|
Apart from waiting for the ES6 work, is this otherwise okay? I'd like to get it heading towards shipping in Thunderbird. |
|
This is very similar to #418. I have not gone in details, but for me it seems both changesets approach problems with BYMONTHDAY in a different ways. |
I do not like how you phrase things in your comments here in the last weeks. It sounds rather pushy and impolite. I myself will close the other PR when I have time to cross check if the test cases there are worth keeping in addition to the ones added in the other two PRs. If anybody wants to close it earlier, he could do so. |
moz-v2v-gh
pushed a commit
to mozilla/releases-comm-central
that referenced
this pull request
Oct 3, 2022
…le greater than the number of days in the start month. r=#thunderbird-reviewers,mkmelin kewisch/ical.js#531 Differential Revision: https://phabricator.services.mozilla.com/D158472 --HG-- extra : rebase_source : bdc9ddfc44d0eed8544fc8a01b8ec2e3ef345cd1 extra : amend_source : 98759bbffa6371ecf3ec3e46699cd13daaab898b
…n the number of days in the start month.
darktrojan
force-pushed
the
overflow-bymonthday
branch
from
455b663 to
6264125
Compare
leftmostcat
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets tricky. If the starting month doesn't have an occurrence (e.g. June has no 31st day), we need to find the next month that does. It's possible to have a sequence of 3 months without as 31st at an interval of 2 (February, April, June) so we might need to look for the next month three times.
(In the Gregorian calendar it IS possible to miss 7 occurrences if the interval is 12 and the start is a February late in a century, but that's absurd and I will be dead by then.)