Fix paths in CLDReconstruction.xml and add a test running with Marlin #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did this not show up the tests? |
|
There wasn't a test before running with Marlin, I added one. |
jmcarcell
changed the title
andresailer
approved these changes
Jan 16, 2025
|
Thanks! |
|
I think we should just get rid of the XML. I only kept it around so that it is understandable what was used as the basis in the past, but I would not want to maintain two versions of the reconstruction... |
|
Maybe, but right now it is the only way to run with the Pandora monitoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES