Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add association between ReconstructedParticle and Vertex #133

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

fdplacido
Copy link
Contributor

BEGINRELEASENOTES

  • Add association between ReconstructedParticle and Vertex

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

What is the use case for this? In principle a Vertex already has a relation to a ReconstructedParticle and vice versa.

- edm4hep::ReconstructedParticle associatedParticle //reconstructed particle associated to this vertex.

and
- edm4hep::Vertex startVertex //start vertex associated to this particle

@andresailer
Copy link
Collaborator

@tmadlener
Copy link
Contributor

Ah yes, I see. I have opened an issue in podio to support arbitrary associations. Not entirely sure about the timeline though ;)

In principle I don't see anything that speaks against merging this now and then reworking things once (if) arbitrary associations arrive in podio.

edm4hep.yaml Outdated Show resolved Hide resolved
edm4hep.yaml Outdated Show resolved Hide resolved
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
@fdplacido
Copy link
Contributor Author

Ah yes, I see. I have opened an issue in podio to support arbitrary associations. Not entirely sure about the timeline though ;)

In principle I don't see anything that speaks against merging this now and then reworking things once (if) arbitrary associations arrive in podio.

I would say we go ahead and merge this, since there are other association collections around already. All those would change once the arbitrary collections are in place.

@fdplacido fdplacido force-pushed the add_association_collection branch from 8b1109d to 0ba65d8 Compare December 9, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants