Give the utils target a more discernible output name #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's also possible to keep the name of cmake target and only change the name of its output: set_target_properties(utils PROPERTIES OUTPUT_NAME "edm4hepUtils")so the target (assuming it got promoted to a shared library) is known as |
|
Very nice, I wasn't aware of that. Thanks :) |
tmadlener
commented
Apr 18, 2024
tmadlener
changed the title
jmcarcell
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
utils(currently INTERFACE only) target appears asedm4hepUtils"on disk" in order to avoid having on overly genericlibutils.soonce it actually becomes a shared library.ENDRELEASENOTES
This is a small side-effect that can easily be split off from #268