Update the schema diagram to reflect TrackerHit as interface #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
jmcarcell
approved these changes
May 10, 2024
There was a problem hiding this comment.
I'm not fully convinced by how the interface is displayed, doesn't look very clear that the arrows from TrackerHit to TrackerHitPlane or TrackerHit3D are different from the other arrows in the diagram. But I don't have any suggestions with the space that is available, so 👍
|
Yeah, I am also not yet entirely convinced it's the best solution, but it is kind of close to what was there before and I didn't have to rework the full diagram ;) |
|
No one has said anything so I think this can go in |
jmcarcell
added a commit
that referenced
this pull request
May 27, 2024
…o reflect TrackerHit as interface (#302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
TrackerHitas interfaceTrackerHit3Das new typeENDRELEASENOTES